Skip to content

GH4150/4197: Codegen styling & nullable param#4259

Merged
gep13 merged 1 commit intocake-build:developfrom
devlead:feature/gh-4150/gh-4197
Nov 18, 2023
Merged

GH4150/4197: Codegen styling & nullable param#4259
gep13 merged 1 commit intocake-build:developfrom
devlead:feature/gh-4150/gh-4197

Conversation

@devlead
Copy link
Copy Markdown
Member

@devlead devlead commented Nov 16, 2023

Results in about 5k fewer lines of code generated.
Fixes issues with nullable return types and parameters.

@devlead devlead requested a review from a team November 17, 2023 14:48
Copy link
Copy Markdown
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 enabled auto-merge November 18, 2023 16:50
* fixes cake-build#4150 - Fix styling warnings
* fixes cake-build#4197 - Fix parameter nullability error
@gep13 gep13 force-pushed the feature/gh-4150/gh-4197 branch from 6370a2d to a9d5d99 Compare November 18, 2023 17:50
@gep13 gep13 merged commit 829df67 into cake-build:develop Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants