Skip to content

File type check on macosx (if file is "dylib")#4206

Merged
devlead merged 9 commits intocake-build:developfrom
Forks4Work-Microsoft-Xamarin:fix-issue-3996-bad-il-format-macosx
Oct 1, 2023
Merged

File type check on macosx (if file is "dylib")#4206
devlead merged 9 commits intocake-build:developfrom
Forks4Work-Microsoft-Xamarin:fix-issue-3996-bad-il-format-macosx

Conversation

@moljac
Copy link
Copy Markdown
Contributor

@moljac moljac commented Sep 19, 2023 •
edited
Loading

Context: #3996

Added filetype/extension check.

Error experienced:

Error: Bad IL format. 
The format of the file 
    '/Users/runner/work/1/s/tools/Addins/runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple.4.3.0/runtimes/osx.10.10-x64/native/System.Security.Cryptography.Native.Apple.dylib' 
is invalid. 
An error occurred when executing task Error: .NET CLI: Process returned an error (exit code 1)

The error was experienced at intermittent intervals in CI (and local, but not so often) builds for 2 repos:

https://github.com/xamarin/AndroidX
https://github.com/xamarin/GooglePlayServicesComponents

In last few weeks, alsmost all builds fail regularly.

xamarin/GooglePlayServicesComponents#801

@moljac
Copy link
Copy Markdown
Contributor Author

moljac commented Sep 26, 2023

@devlead @patriksvensson @gep13

Hi

Would you be so kind and review this PR, please? We have blocking issue on GPS-FB-MLKit (GooglePlayServicesComponents) both local and CI builds

https://github.com/xamarin/GooglePlayServicesComponents

devlead
devlead requested changes Sep 28, 2023
View reviewed changes
@moljac
Copy link
Copy Markdown
Contributor Author

moljac commented Sep 29, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 29, 2023

Commenter does not have sufficient privileges for PR 4206 in repo cake-build/cake

devlead
devlead requested changes Sep 29, 2023
View reviewed changes
devlead
devlead requested changes Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moljac Other than the missing periods in extensions it LGTM 👍
Could you please address, rebase against latest upstream develop branch, and squash/fixup into one commit, then I'll take a final look.

@moljac
Copy link
Copy Markdown
Contributor Author

moljac commented Oct 1, 2023

I cannot squash. Probably because I updated branch with merge commit (I was in a hurry and doing few things in parallel) and forgot to squash before update.

devlead
devlead approved these changes Oct 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead linked an issue Oct 1, 2023 that may be closed by this pull request
Error: Bad IL format with Cake MacOSX (2.3.0 - 3.1.0) #3996
Closed
2 tasks
@devlead devlead merged commit 4ae30f3 into cake-build:develop Oct 1, 2023
@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 1, 2023

@moljac your changes have been merged, thanks for your contribution 👍

@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 1, 2023

@moljac FYI a pre-release package is now available on our Azure Artifacts feed:
https://dev.azure.com/cake-build/Cake/_artifacts/feed/cake/NuGet/Cake.Tool/overview/3.2.0-alpha0025

@moljac moljac deleted the fix-issue-3996-bad-il-format-macosx branch October 2, 2023 10:06
@moljac
Copy link
Copy Markdown
Contributor Author

moljac commented Oct 2, 2023

@moljac FYI a pre-release package is now available on our Azure Artifacts feed: https://dev.azure.com/cake-build/Cake/_artifacts/feed/cake/NuGet/Cake.Tool/overview/3.2.0-alpha0025

Great! It works locally. 2 GPS-FB-MLKit PRs build nicely.

When is 3.2.0 supposed to be released?

Thanks a lot!

@moljac
Copy link
Copy Markdown
Contributor Author

moljac commented Oct 10, 2023

Some feedback: 3.2.0 preview fixes the issue. Confimed on 2 local MBPs and on CI (GPS-FB-MLKit repo https://github.com/xamarin/GooglePlayServicesComponents)

thanks

@moljac moljac mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devlead devlead devlead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Bad IL format with Cake MacOSX (2.3.0 - 3.1.0)

2 participants

@moljac @devlead