Add NodeReuse property to DotNetMSBuildSettings#4194
Merged
augustoproiete merged 2 commits intocake-build:developfrom Sep 29, 2023
Merged
Add NodeReuse property to DotNetMSBuildSettings#4194augustoproiete merged 2 commits intocake-build:developfrom
augustoproiete merged 2 commits intocake-build:developfrom
Conversation
augustoproiete
requested changes
Jul 16, 2023
Member
augustoproiete
left a comment
augustoproiete
left a comment
There was a problem hiding this comment.
LGTM overall. Small change on the command-line
src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs
Show resolved
Hide resolved
src/Cake.Common.Tests/Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs
Outdated
Show resolved
Hide resolved
augustoproiete
force-pushed
the
rmarusyk/4144
branch
from
54dba90 to
449eb23
Compare
|
@augustoproiete seems like this one somehow got stuck pending approval despite having approval? 🤔 |
devlead
force-pushed
the
rmarusyk/4144
branch
from
449eb23 to
4ed7c72
Compare
Member
|
@Marusyk your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NodeReuse property to DotNetMSBuildSettings and tests
Fixes #4144
Please review,
Thank you in advance