Upgrade Spectre.Console to v0.46.0#4140
Merged
augustoproiete merged 2 commits intocake-build:developfrom Apr 5, 2023
FrankRay78:Update-spectre.console-to-0.46.0
Merged
Upgrade Spectre.Console to v0.46.0#4140augustoproiete merged 2 commits intocake-build:developfrom FrankRay78:Update-spectre.console-to-0.46.0
augustoproiete merged 2 commits intocake-build:developfrom
FrankRay78:Update-spectre.console-to-0.46.0
Conversation
Contributor
Author
|
Looks like |
Member
|
@FrankRay78 |
2 tasks
augustoproiete
changed the title
Member
|
@FrankRay78 your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades spectre.console from 0.45.0 to 0.46.0 (latest) by upgrading the NuGet package reference, and the subsequent minor build issue introduced (see: #4138) has been fixed by a trivial code change.
Background: my interest in upgrading to the latest spectre.console is in anticipation of being able to fix this cake issue, #3279. The necessary change to spectre.console has been made and committed (714cf179cb349597a8b775287ac8299584b18617), although it does not reside in the 0.46.0 release and is scheduled for 0.47.0. Either way, I wanted to upgrade the version of spectre.console used by cake to the latest and address any issues that may arise, to ease the future upgrade to 0.47.0
nb. spectre.console release notes for 0.46.0 are here: https://github.com/spectreconsole/spectre.console/releases/tag/0.46.0
The biggest visible improvement arising from using spectre.console 0.46.0 for cake users is showing the default value of any arguments, see: