GH-4128: Fix Inconsistent determination of positional Argument when using context.Arguments versus context.Argument#4139
Merged
augustoproiete merged 1 commit intocake-build:developfrom Apr 22, 2023
Conversation
2 tasks
Member
|
Thanks for the PR @EdLichtman. Could you please reply to this as per the instructions here: #4139 (comment) ? |
augustoproiete
changed the title
Contributor
Author
|
@augustoproiete I can do that, but it's not the complete changelist you have, and like I mentioned in Issue #4128 I haven't yet been able to run the tests. Would it be alright for me to perform the checks and get my change in without it? It looks like I haven't fully implemented the changes you implemented, so it's still an incomplete change. |
Member
|
@EdLichtman That's fine. I can merge your changes and mine on the same PR - or you can bring the missing changes I did to this MR, and we close mine |
Contributor
Author
|
@microsoft-github-policy-service agree |
augustoproiete
added
Response from Cake team required
and removed
Waiting for issuer feedback
labels
…ment when using context.Arguments versus context.Argument Co-authored-by: "C. Augusto Proiete" <[email protected]>
2 tasks
Member
|
@EdLichtman your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Arguments versus context.Argument