GH4046/GH4047: Add Finally<T> & TaskOf<T>#4048
Merged
devlead merged 4 commits intocake-build:developfrom Nov 7, 2022
Merged
Conversation
Member
devlead
commented
Nov 4, 2022
devlead
commented
- fixes Add typed data context CakeTaskBuilder.Finally<T> overload #4046
- fixes Add typed CakeTaskBuilder / TaskOf<T>() to easier work with typed data context #4047
bjorkstromm
approved these changes
Nov 7, 2022
Member
bjorkstromm
left a comment
bjorkstromm
left a comment
There was a problem hiding this comment.
LGTM! Thanks @devlead for fixing this!
gep13
requested changes
Nov 7, 2022
Member
gep13
left a comment
gep13
left a comment
There was a problem hiding this comment.
Just a couple of things that I think need changed, otherwise LGTM!
devlead
force-pushed
the
feature/gh-4046/gh-4047
branch
from
d987b87 to
5d5dfb6
Compare
Member
Author
Should've be addressed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.