Skip to content

GH2863: Add GitHub Actions workflow commands#4033

Merged
devlead merged 2 commits intocake-build:developfrom
gitfool:gh2863
Oct 31, 2022
Merged

GH2863: Add GitHub Actions workflow commands#4033
devlead merged 2 commits intocake-build:developfrom
gitfool:gh2863

Conversation

@gitfool
Copy link
Copy Markdown
Contributor

@gitfool gitfool commented Oct 30, 2022

@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 31, 2022

@gitfool
Copy link
Copy Markdown
Contributor Author

gitfool commented Oct 31, 2022

It might take a couple of iterations to get the integration tests working satisfactorily. Bear with me.

@gitfool
Copy link
Copy Markdown
Contributor Author

gitfool commented Oct 31, 2022

@devlead I see the group but not the message inside the group for some reason. Is this something to do with how the integration tests are run? What am I missing?

2022-10-31T07:36:06.3862735Z ##[group]Cake group
2022-10-31T07:36:06.3863076Z ##[endgroup]

@gitfool gitfool force-pushed the gh2863 branch 2 times, most recently from 19ea230 to 1d8a35c Compare October 31, 2022 08:46
@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 31, 2022

@devlead I see the group but not the message inside the group for some reason. Is this something to do with how the integration tests are run? What am I missing?

2022-10-31T07:36:06.3862735Z ##[group]Cake group
2022-10-31T07:36:06.3863076Z ##[endgroup]

Think it needs to be quoted, example of the command used in wild

if (BuildSystem.GitHubActions.IsRunningOnGitHubActions)
{
    TaskSetup(context=> System.Console.WriteLine($"::group::{context.Task.Name.Quote()}"));
    TaskTeardown(context=>System.Console.WriteLine("::endgroup::"));
}

https://github.com/devlead/DPI/blob/2cd985ee19359486d1911f03f6066d98e99ca2cf/build/helpers.cake#L30-L34

Result:
image
https://github.com/devlead/DPI/actions/runs/3348953578/jobs/5548532403#step:5:28

@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 31, 2022

Hmm also looks like :: instead of ## 🤔

@gitfool
Copy link
Copy Markdown
Contributor Author

gitfool commented Oct 31, 2022

No, doesn't need to be quoted, and that output is from the log which seems to be related to azure pipelines legacy. Basically the group is working fine. It's the following information output that's missing. Same problem with the secret test.

I've been using (unquoted) groups for a while: https://github.com/gitfool/Cake.Dungeon/blob/3d9f8c6fd79cb74089e7f4d6d70c68fda5c20662/scripts/bootstrap.cake#L24-L38

image

@gitfool
Copy link
Copy Markdown
Contributor Author

gitfool commented Oct 31, 2022

Annotations are working as expected. It's only the Information output that's missing. I expect it will work fine outside of the integration tests. Good enough for now?

@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 31, 2022

Annotations are working as expected. It's only the Information output that's missing. I expect it will work fine outside of the integration tests. Good enough for now?

Ah, the information you won't see as the integration tests run at a lower verbosity.

I switched to a Console.WriteLine if it turns up I'm happy ;)

Copy link
Copy Markdown
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM 👍

@devlead devlead merged commit 5c0c294 into cake-build:develop Oct 31, 2022
@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 31, 2022

@gitfool your changes have been merged, thanks for your contribution 👍

@gitfool gitfool deleted the gh2863 branch October 31, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for GitHub Action workflow commands

2 participants