Skip to content

#3867 Rename attribute WindowsFact-> WindowsFactAttribute#3988

Merged
devlead merged 1 commit intocake-build:developfrom
ivanbibik:3867
Oct 17, 2022
Merged

#3867 Rename attribute WindowsFact-> WindowsFactAttribute#3988
devlead merged 1 commit intocake-build:developfrom
ivanbibik:3867

Conversation

@ivanbibik
Copy link
Copy Markdown

Fixes #3867
Rename attribute WindowsFact->WindowsFactAttribute.

Thank you in advance

Copy link
Copy Markdown
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead enabled auto-merge October 17, 2022 08:26
@devlead devlead merged commit 7c2b3b2 into cake-build:develop Oct 17, 2022
@devlead
Copy link
Copy Markdown
Member

devlead commented Oct 17, 2022

@ivanbibik your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename WindowsFact to WindowsFactAttribute to follow best practices

2 participants