GH2519: Changes for stable Visual Studio 2019 release#2520
GH2519: Changes for stable Visual Studio 2019 release#2520devlead merged 1 commit intocake-build:developfrom Roemer:feature/GH-2519-VS2019_support
Conversation
| "/Program86/Microsoft Visual Studio/2017/Enterprise/MSBuild/15.0/Bin/amd64/MSBuild.exe", | ||
| "/Program86/Microsoft Visual Studio/2019/Preview/MSBuild/Current/Bin/MSBuild.exe", | ||
| "/Program86/Microsoft Visual Studio/2019/Preview/MSBuild/Current/Bin/amd64/MSBuild.exe", | ||
| "/Program86/Microsoft Visual Studio/2019/Professional/MSBuild/Current/Bin/MSBuild.exe", |
There was a problem hiding this comment.
Is there a reason that you chose Professional here, rather than Enterprise, similar to what was done for 2017?
There was a problem hiding this comment.
As I only have the Professional version, I can verify only that path.
There was a problem hiding this comment.
But if you want, for consistency reasons, I can us the same as it is fairly obvious that it should be correct.
There was a problem hiding this comment.
There is no "need" for them to be consistent, I was just curious.
There was a problem hiding this comment.
I think it would be good if we added tests for the other editions as well.
There was a problem hiding this comment.
@patriksvensson Should I have a look at that (that would probably mean making the MSBuildRunnerFixture configurable (to "fake" different VS installation"). Or should that be done probably later as I think cake should have VS2019 support ready asap.
|
For some reason, I cannot access the bitrise ci to check why it failed. |
Unfortunately, the bitrise builds can't be made public :-( Looking at the log, this is nothing to do with your change, so don't worry about it. Something we need to fix. |
Actually they now can, but they need to be recreated, I've recreated the Ubuntu Bitrise build and disabled old build, changed which is required for PRs to the new. Issue was an expired ssh key, new build uses https which is what they allow for public projects. |
|
Bitrise macOS build now recreated and public. Old OSX disabled. |
|
So how do we go on from here? Are any more changes needed? |
|
@Roemer your changes have been merged, thanks for your contribution 👍 |
|
@devlead Hi, do you know when will it be in a release? |
5 participants
Changes regarding the release of Visual Studio 2019.
Fixes #2519