Provide tasks rather than just names since the engine looks them up anyway

jnm2 · jnm2 · commit 5fd3cc6aa37a · 2017-08-29T19:32:36.000-04:00
diff --git a/src/Cake.Core/CakeEngine.cs b/src/Cake.Core/CakeEngine.cs
@@ -129,18 +129,23 @@ public CakeReport RunTarget(ICakeContext context, IExecutionStrategy strategy, s
 
             try
             {
-                var executingTasks = graph.Traverse(target);
+                var executingTaskNames = graph.Traverse(target);
+
+                var executingTasks = new CakeTask[executingTaskNames.Count];
+                for (var i = 0; i < executingTasks.Length; i++)
+                {
+                    var name = executingTaskNames[i];
+                    executingTasks[i] = _tasks.FirstOrDefault(x => x.Name.Equals(name, StringComparison.OrdinalIgnoreCase));
+                    Debug.Assert(executingTasks[i] != null, "Node should not be null.");
+                }
+
                 PerformSetup(strategy, context, executingTasks);
 
                 var stopWatch = new Stopwatch();
                 var report = new CakeReport();
 
-                foreach (var taskNode in executingTasks)
+                foreach (var task in executingTasks)
                 {
-                    // Get the task.
-                    var task = _tasks.FirstOrDefault(x => x.Name.Equals(taskNode, StringComparison.OrdinalIgnoreCase));
-                    Debug.Assert(task != null, "Node should not be null.");
-
                     // Is this the current target?
                     var isTarget = task.Name.Equals(target, StringComparison.OrdinalIgnoreCase);
 
@@ -199,7 +204,7 @@ public void RegisterTaskTeardownAction(Action<ITaskTeardownContext> action)
         /// </summary>
         public event EventHandler<TaskTeardownEventArgs> TaskTeardown;
 
-        private void PerformSetup(IExecutionStrategy strategy, ICakeContext context, IReadOnlyList<string> tasksToExecute)
+        private void PerformSetup(IExecutionStrategy strategy, ICakeContext context, IReadOnlyList<CakeTask> tasksToExecute)
         {
             var setupContext = new SetupContext(context, tasksToExecute);
             PublishEvent(Setup, new SetupEventArgs(setupContext));
diff --git a/src/Cake.Core/ISetupContext.cs b/src/Cake.Core/ISetupContext.cs
@@ -15,6 +15,6 @@ public interface ISetupContext : ICakeContext
         /// Gets the ordered list of tasks which are about to be executed.
         /// The target task is listed last.
         /// </summary>
-        IReadOnlyList<string> TasksToExecute { get; }
+        IReadOnlyList<CakeTask> TasksToExecute { get; }
     }
 }
diff --git a/src/Cake.Core/SetupContext.cs b/src/Cake.Core/SetupContext.cs
@@ -16,7 +16,7 @@ public sealed class SetupContext : CakeContextAdapter, ISetupContext
         /// </summary>
         /// <param name="context">The Cake Context</param>
         /// <param name="tasksToExecute">The ordered list of tasks which are about to be executed with the target task listed last.</param>
-        public SetupContext(ICakeContext context, IReadOnlyList<string> tasksToExecute)
+        public SetupContext(ICakeContext context, IReadOnlyList<CakeTask> tasksToExecute)
             : base(context)
         {
             TasksToExecute = tasksToExecute;
@@ -26,6 +26,6 @@ public SetupContext(ICakeContext context, IReadOnlyList<string> tasksToExecute)
         /// Gets the ordered list of tasks which are about to be executed.
         /// The target task is listed last.
         /// </summary>
-        public IReadOnlyList<string> TasksToExecute { get; }
+        public IReadOnlyList<CakeTask> TasksToExecute { get; }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,6 @@ public interface ISetupContext : ICakeContext`
`15`	`15`	`/// Gets the ordered list of tasks which are about to be executed.`
`16`	`16`	`/// The target task is listed last.`
`17`	`17`	`/// </summary>`
`18`		`- IReadOnlyList<string> TasksToExecute { get; }`
	`18`	`+ IReadOnlyList<CakeTask> TasksToExecute { get; }`
`19`	`19`	`}`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public sealed class SetupContext : CakeContextAdapter, ISetupContext`
`16`	`16`	`/// </summary>`
`17`	`17`	`/// <param name="context">The Cake Context</param>`
`18`	`18`	`/// <param name="tasksToExecute">The ordered list of tasks which are about to be executed with the target task listed last.</param>`
`19`		`- public SetupContext(ICakeContext context, IReadOnlyList<string> tasksToExecute)`
	`19`	`+ public SetupContext(ICakeContext context, IReadOnlyList<CakeTask> tasksToExecute)`
`20`	`20`	`: base(context)`
`21`	`21`	`{`
`22`	`22`	`TasksToExecute = tasksToExecute;`
`@@ -26,6 +26,6 @@ public SetupContext(ICakeContext context, IReadOnlyList<string> tasksToExecute)`
`26`	`26`	`/// Gets the ordered list of tasks which are about to be executed.`
`27`	`27`	`/// The target task is listed last.`
`28`	`28`	`/// </summary>`
`29`		`- public IReadOnlyList<string> TasksToExecute { get; }`
	`29`	`+ public IReadOnlyList<CakeTask> TasksToExecute { get; }`
`30`	`30`	`}`
`31`	`31`	`}`