Conversation
Collaborator
dremin
commented
Nov 6, 2025
dremin
commented
- Fixed IShellLink leak
- Introduced method to stop menu bar extension controls, so that they don't leak when a menu bar is closed
- Fixed other misc menu extra leaks
- Fixed menu commands event handler leak
- Hotkeys improved:
- Hotkeys are no longer managed within individual instances of controls, which was bad, and fixes misc issues including leaks
- Hotkeys that open menus now open the one on the same monitor as the mouse, if multiple menu bars are present
- Toggling the Cairo and programs menu are now implemented as commands, which the hotkeys invoke
- Toggling menu bar items no longer requires Cairo restart
- Moved search initialization outside of the search control
- Hide search until initialized to prevent confusion
- Hotkeys are no longer managed within individual instances of controls, which was bad, and fixes misc issues including leaks - Hotkeys that open menus now open the one on the same monitor as the mouse, if multiple menu bars are present - Toggling the Cairo and programs menu are now implemented as commands, which the hotkeys invoke - Introduced method to stop menu bar extension controls, so that they don't leak - Toggling menu bar items no longer requires Cairo restart - Fixed misc menu extra leaks
This only needs to be done once, rather than each time a control is created. Hides search until initialized to prevent confusion.
josuave
approved these changes
Nov 6, 2025
|
|
||
| try | ||
| { | ||
| new HotKey(Key.S, HotKeyModifier.Win | HotKeyModifier.NoRepeat, OnShowSearchHotkey); |
Collaborator
There was a problem hiding this comment.
We should look at making these hot keys configurable and settings. I believe clocks also had one that looked pretty hard coded. Just an observation not anything to block this pr
Collaborator
Author
There was a problem hiding this comment.
Agreed! I started moving some of these to commands as I would like to allow users to freely configure hotkeys to trigger commands, and move all of these to that configurable system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.