Fix leaks causing menu bar, taskbar, and desktop instances to be retained in memory#899
Merged
Fix leaks causing menu bar, taskbar, and desktop instances to be retained in memory#899
Conversation
Also fix TryGetCategoryDisplayNameByProcId to not return the current window
josuave
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throughout the application lifecycle, we may close or open these windows for various reasons (display changes, preference changes, etc). Unfortunately, previously these windows would always remain in memory after being closed, for multiple reasons. The changes in this PR plug the leaks that were causing this to happen.
Menu bar
Desktop
Taskbar
TryGetCategoryDisplayNameByProcIdto not return the current window