Skip to content

Use injected settings more#827

Merged
josuave merged 2 commits intomasterfrom
inject-settings-more
Jul 25, 2024
Merged

Use injected settings more#827
josuave merged 2 commits intomasterfrom
inject-settings-more

Conversation

@dremin
Copy link
Collaborator

@dremin dremin commented Jul 24, 2024

  • Changed direct references of Settings.Instance to use the injected Settings instance where readily available to do so
    • There are still a few direct references left that will become easier to change after future PRs.
  • Simplified SettingsUI bindings by setting the DataContext
  • Unrelated: Fixed mouse back/forward buttons navigating the desktop when the dynamic desktop is disabled.

@dremin dremin requested a review from josuave July 24, 2024 23:52
@josuave josuave merged commit 84b85eb into master Jul 25, 2024
@josuave josuave deleted the inject-settings-more branch July 25, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants