Add togglable Places & Programs#821
Merged
dremin merged 1 commit intocairoshell:masterfrom Jul 17, 2024
Merged
Conversation
Contributor
Author
|
I think i just messed up the branch? |
Contributor
Author
|
I quickly re-implemented it and force pushed it. Sorry about that 😅 Since the setup places method is gone, i instead put the updating of visibility into setupChildren. I hope that's fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the ability to toggle the Places and Programs option in the menu bar. I'd like to disable it as i don't really use it anyways and it takes up space for my way too big tray.
I'm quite unfamiliar with the code base and just went off of how everything else, i think, is done.
For translations i'm just piggy backing off of the existing translations for the 2 options.
If i made a mistake or it's not up to standard then let me know.