Skip to content

Catch extension load errors that could halt init#814

Merged
josuave merged 2 commits intomasterfrom
extension-load-safer
May 29, 2024
Merged

Catch extension load errors that could halt init#814
josuave merged 2 commits intomasterfrom
extension-load-safer

Conversation

@dremin
Copy link
Collaborator

@dremin dremin commented May 28, 2024

Improves the robustness of extension loading so that extensions throwing exceptions at startup don't prevent Cairo startup.

Also added a couple adjacent improvements:

  • Fixed an old TODO where logs weren't emitted early on during startup
  • Improved Cairo menu item extension insertion logic so that it's not sensitive to us adding/removing items

@dremin dremin added the Core Features core to Cairo label May 28, 2024
@dremin dremin requested a review from josuave May 28, 2024 23:44
@josuave josuave merged commit 83257d3 into master May 29, 2024
@josuave josuave deleted the extension-load-safer branch May 29, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Features core to Cairo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants