Repository navigation
Commit 379e320
committed
[Impeller] Do not clamp DrawDisplayList cull rect to the root render target
DrawDisplayList culls a nested DisplayList against
Canvas::GetLocalCoverageLimit(), which always intersects with the root
render target. Inside a subpass this is too tight: content outside the
root RT can still end up on-screen, for example when an ancestor
SaveLayer has a matrix image filter that translates it. Such content is
culled and never drawn.
Add a clamp_to_root parameter (default true) and pass false only from
DrawDisplayList. SaveLayer keeps the clamped value, because it can be
returned directly as the subpass size and unclamping it would grow
offscreen textures. On the root pass the two values are identical.
Test: DrawDisplayListInTranslatedSaveLayerIsNotCulled.
Fixes flutter#1958591 parent b5879a3 commit 379e320
4 files changed
Lines changed: 48 additions & 3 deletions
File tree
- engine/src/flutter/impeller/display_list
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2861 | 2861 | | |
2862 | 2862 | | |
2863 | 2863 | | |
| 2864 | + | |
| 2865 | + | |
| 2866 | + | |
| 2867 | + | |
| 2868 | + | |
| 2869 | + | |
| 2870 | + | |
| 2871 | + | |
| 2872 | + | |
| 2873 | + | |
| 2874 | + | |
| 2875 | + | |
| 2876 | + | |
| 2877 | + | |
| 2878 | + | |
| 2879 | + | |
| 2880 | + | |
| 2881 | + | |
| 2882 | + | |
| 2883 | + | |
| 2884 | + | |
| 2885 | + | |
| 2886 | + | |
| 2887 | + | |
| 2888 | + | |
| 2889 | + | |
| 2890 | + | |
| 2891 | + | |
| 2892 | + | |
| 2893 | + | |
| 2894 | + | |
2864 | 2895 | | |
2865 | 2896 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1790 | 1790 | | |
1791 | 1791 | | |
1792 | 1792 | | |
1793 | | - | |
| 1793 | + | |
1794 | 1794 | | |
1795 | 1795 | | |
1796 | 1796 | | |
| |||
1823 | 1823 | | |
1824 | 1824 | | |
1825 | 1825 | | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
| 1830 | + | |
| 1831 | + | |
| 1832 | + | |
1826 | 1833 | | |
1827 | 1834 | | |
1828 | 1835 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
157 | 163 | | |
158 | 164 | | |
159 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
827 | 827 | | |
828 | 828 | | |
829 | 829 | | |
830 | | - | |
| 830 | + | |
| 831 | + | |
831 | 832 | | |
832 | 833 | | |
833 | 834 | | |
| |||
0 commit comments