Remove explicit VOLUME instructions#220
Merged
hairyhenderson merged 1 commit intocaddyserver:masterfrom Apr 25, 2022
OCram85:removeVolume
Merged
Remove explicit VOLUME instructions#220hairyhenderson merged 1 commit intocaddyserver:masterfrom OCram85:removeVolume
hairyhenderson merged 1 commit intocaddyserver:masterfrom
OCram85:removeVolume
Conversation
OCram85
changed the title
hairyhenderson
changed the title
Contributor
|
I've rebased and updated the PR to avoid modifying the 2.4 images, as I only want this change to apply from v2.5 on. Once this is updated for v2.5.0 we'll stop the 2.4 images anyway. |
Contributor
|
(the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Summary
Removes the controversial VOLUME instructions in the Dockerfiles.
📑 Test Plan
Details / Justification
📚 Additional Notes
As already mentioned, there should be an additional warning message about the changes and how to deal with the dopped implicit volume definitions
VOLUMEinstructions #118