reverseproxy: ignore duplicate collector registration error#6820
Merged
mohammed90 merged 1 commit intomasterfrom Feb 4, 2025
Merged
reverseproxy: ignore duplicate collector registration error#6820mohammed90 merged 1 commit intomasterfrom
mohammed90 merged 1 commit intomasterfrom
Conversation
Signed-off-by: Mohammed Al Sahaf <[email protected]>
mholt
approved these changes
Feb 1, 2025
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
LGTM if it works as expected; the panic makes me a little nervous but I assume either that should never happen unless there's a bug, or the panic is necessary for flow control and it's unavoidable.
Member
|
Thanks Mohammed! |
mohammed90
added a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
…ver#6820) Signed-off-by: Mohammed Al Sahaf <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not very happy with the approach, but I cannot think of another one. Others who can see a better solution are welcome to suggest.
Fixes #6813