reverseproxy: Add tls_curves option to HTTP transport#5851
Merged
francislavoie merged 1 commit intocaddyserver:masterfrom Jan 13, 2024
Merged
reverseproxy: Add tls_curves option to HTTP transport#5851francislavoie merged 1 commit intocaddyserver:masterfrom
tls_curves option to HTTP transport#5851francislavoie merged 1 commit intocaddyserver:masterfrom
Conversation
|
|
bwesterb
commented
Oct 2, 2023
francislavoie
changed the title
tls_curves option to HTTP transport
bwesterb
force-pushed
the
reverse-proxy-curves
branch
from
a98846c to
730ffe8
Compare
mholt
approved these changes
Oct 3, 2023
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Thank you for this. I noticed it doesn't reject unknown curve names, but maybe that's OK for a niche feature for now. I don't think it will break anything at least.
Since this is a new feature, it will have to wait until 2.9 but we can at least merge it in whenever you're ready.
Did you want to add an error if there's an unrecognized input?
Contributor
Author
I'm mimicking the behaviour of I can add an error for both if you like? |
Example Caddyfile
localhost {
reverse_proxy https://example.com {
transport http {
tls_curves secp521r1
}
}
}
francislavoie
force-pushed
the
reverse-proxy-curves
branch
from
730ffe8 to
45c8d91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example Caddyfile
Long term goal is to be able to configure post-quantum for Caddy -> upstream.