Fix for missing content-length header when using QUIC#1501
Merged
mholt merged 6 commits intocaddyserver:masterfrom Mar 10, 2017
Merged
Fix for missing content-length header when using QUIC#1501mholt merged 6 commits intocaddyserver:masterfrom
mholt merged 6 commits intocaddyserver:masterfrom
Conversation
If request.ContentLength is set then it will be used instead of getting it from request.Header map since quic-go(quic-go/quic-go@bb24be8) will not store (and pass) the Content-Length header using its header map. This fixes a potential issue where FastCGI POST requests body empty when QUIC is enabled. (caddyserver#1370)
quic-go uses int64 for contentLength
ssut
changed the title
the data type for contentLength
…ix_fastcgi_using_quic * 'fix_fastcgi_using_quic' of github.com:ssut/caddy: Avoid panic if reloading before server is started
mholt
reviewed
Mar 10, 2017
Member
|
Thanks @ssut - did you verify that this fixes an issue? Is the issue documented? |
Author
|
@mholt I'm pretty sure this fixes the exact issue such like #1370, in this case #1483 (comment). |
Member
|
@ssut By "pretty sure" do you mean it doesn't work before your change, but does work after? If you're sure that's the case, then I'm okay with merging this. |
mholt
approved these changes
Mar 10, 2017
Member
|
Great, thank you @ssut! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If request.ContentLength is set then it will be used instead of getting it from request.Header map since quic-go(quic-go/quic-go@bb24be8) will not store (and pass) the Content-Length header using its header map.