build: add Objective-C ARC support for NPU sources#475
Merged
HenryNdubuaku merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
Signed-off-by: jakmro <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Apple build and iOS test harness to support Objective-C ARC when compiling the ANE NPU Objective-C++ source, ensuring the CoreML-based implementation builds cleanly.
Changes:
- Enable
-fobjc-arcfor the ANE NPU Objective-C++ source (npu_ane.mm) in the Apple CMake build. - Add explicit
externprototypes for auto-discovered iOS test entrypoints in the generatedAppDelegate.mm.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ios/CactusTest/CactusTest/AppDelegate.mm | Adds extern int test_*_main(); declarations for the generated iOS test runner calls. |
| apple/CmakeLists.txt | Applies -fobjc-arc compile flag to the ANE NPU Objective-C++ source file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.