Skip to content

Language detection#471

Merged
HenryNdubuaku merged 9 commits intomainfrom
language-detection
Mar 3, 2026
Merged

Language detection#471
HenryNdubuaku merged 9 commits intomainfrom
language-detection

Conversation

@ParkiratS
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@mshast mshast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When going through the changes, there were a couple things that caused some errors, so I thought I'd just list them here just in case it causes errors larger than just a local thing.

For some files, I have import errors due to the telemetry header file not being found, but those are an easy fix (adding ../ to those files). I had a similar issue with is_same_v(), and that might also be a local issue due to compiler versions.

Once those issues were solved, I still had some issues with tests not being able to load. The main test that failed was pcm_transcription because it couldn't find it anywhere, which I think is another local issue, but I'll add to the review if it seems more than just that. With the tests using cactus test, it gave me issues saying it couldn't load VAD despite having it downloaded. Finally, I would see if it's possible to test other languages, as the test in test_stt.cpp is currently only for English.

@HenryNdubuaku HenryNdubuaku marked this pull request as ready for review March 3, 2026 17:18
@HenryNdubuaku HenryNdubuaku merged commit e88f5ca into main Mar 3, 2026
4 of 6 checks passed
@yujonglee yujonglee mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants