adjust manual workflow for model publish#470
Merged
HenryNdubuaku merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Signed-off-by: jakmro <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the model publishing workflow by standardizing YAML serialization to use yaml.safe_dump() for security, adding more input parameters for manual workflow dispatch (pipeline_tag, tags, description), and converting bash string concatenation to proper array handling for safer command argument passing.
Changes:
- Replaced
yaml.dump()withyaml.safe_dump()for YAML serialization in Python code - Improved license extraction logic to use
getattr()for safer attribute access - Added three new workflow inputs:
pipeline_tag,tags, anddescriptionfor manual model publishing - Converted bash FLAGS from string concatenation to array-based argument handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/src/publish_to_hf.py | Standardized YAML serialization with yaml.safe_dump() and improved license attribute access safety |
| .github/workflows/publish_to_hf.yml | Added new workflow input parameters and converted bash string flags to proper array handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HenryNdubuaku
pushed a commit
to cattermelon1234/cactus
that referenced
this pull request
Feb 27, 2026
Signed-off-by: jakmro <[email protected]>
cattermelon1234
pushed a commit
to cattermelon1234/cactus
that referenced
this pull request
Feb 28, 2026
Signed-off-by: jakmro <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.