Merged
Conversation
Signed-off-by: Noah Cylich <[email protected]>
Signed-off-by: Noah Cylich <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an ARM64 self-hosted CI verification workflow plus supporting “golden/exhaustive” and failure-mode tests to validate model loading and runtime behavior during PR verification.
Changes:
- Introduces a new GitHub Actions workflow to build on a self-hosted ARM64 runner and run unit + exhaustive model checks.
- Adds new C++ test executables for exhaustive “golden” verification and model-loading failure modes, plus scripts/data to drive golden runs.
- Extends the CLI/test runner plumbing to support an
--exhaustivemode and adjusts test build/link behavior.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/verify-pr.yml |
New PR verification workflow for self-hosted ARM64, building + running unit and exhaustive tests. |
tests/test_exhaustive.cpp |
New executable to run one golden test case selected by env vars (LLM/VLM/embedding/STT). |
tests/test_model_loading.cpp |
New negative tests for common model-loading failure modes. |
tests/run.sh |
Adds --exhaustive flag and excludes test_exhaustive from the default test discovery. |
tests/golden/golden.json |
Adds a single JSON file containing golden test vectors/expectations. |
tests/golden/generate_golden.sh |
Script to download models and run test_exhaustive in generation mode to aid golden updates. |
tests/CMakeLists.txt |
Refines curl linking logic (APPLE vs system curl) and minor formatting. |
python/src/cli.py |
Wires --exhaustive through cactus test into tests/run.sh. |
cactus/models/model_silero_vad.cpp |
Adds a missing include for Linux builds (but introduces a duplicate). |
.gitignore |
Ignores third_party/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]>
…d_token_id) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]>
Signed-off-by: Noah Cylich <[email protected]>
…e, golden tests Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]>
Signed-off-by: Noah Cylich <[email protected]>
Signed-off-by: Noah Cylich <[email protected]>
Signed-off-by: Noah Cylich <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]>
GCC requires designated initializers to match struct declaration order. Reorder .epsilon/.axis and .output_precision/.stride in OpParams initializations to match the field order in OpParams struct. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]>
Signed-off-by: Noah Cylich <[email protected]>
Signed-off-by: HenryNdubuaku <[email protected]>
cattermelon1234
pushed a commit
to cattermelon1234/cactus
that referenced
this pull request
Feb 28, 2026
* condensed and completed CICD pipeline Signed-off-by: Noah Cylich <[email protected]> * fixing wrong initializer for conv kernels Signed-off-by: Noah Cylich <[email protected]> * fix GCC build errors: designator order and missing Parakeet types Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]> * add missing Config members for Parakeet model (encoder_hidden_act, pad_token_id) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]> * improving naming convention Signed-off-by: Noah Cylich <[email protected]> * add Parakeet model support: config parsing, factory, constant pad_mode, golden tests Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]> * cleaned small edge-cases/improved logs Signed-off-by: Noah Cylich <[email protected]> * Merge branch 'main' into ubuntu-cicd Signed-off-by: Noah Cylich <[email protected]> * Revert artifact changes in cactus/ to match main Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]> * Fix designated initializer ordering for GCC compliance GCC requires designated initializers to match struct declaration order. Reorder .epsilon/.axis and .output_precision/.stride in OpParams initializations to match the field order in OpParams struct. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Noah Cylich <[email protected]> * removing .gitignore changes Signed-off-by: Noah Cylich <[email protected]> * Remove unused transcription tests from test_stt.cpp Signed-off-by: HenryNdubuaku <[email protected]> --------- Signed-off-by: Noah Cylich <[email protected]> Signed-off-by: HenryNdubuaku <[email protected]> Co-authored-by: HenryNdubuaku <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up CI/CD infrastructure for automated PR verification on a self-hosted ARM64 Linux runner.
Workflow (.github/workflows/verify-pr.yml):
INT8/INT4/FP16)
Test plan
Test infrastructure:
check), and VLM
Bug fixes: