add STFT_COMPLEX, derive stft_magnitude via graph composition#395
Merged
HenryNdubuaku merged 3 commits intocactus-compute:mainfrom Feb 24, 2026
Merged
add STFT_COMPLEX, derive stft_magnitude via graph composition#395HenryNdubuaku merged 3 commits intocactus-compute:mainfrom
HenryNdubuaku merged 3 commits intocactus-compute:mainfrom
Conversation
Signed-off-by: Yujong Lee <[email protected]>
Collaborator
|
@yujonglee thanks so much for this! maybe lets swap in the internal logic, of existing fused stft, so we only have one function, to avoid duplicates. |
Contributor
Author
|
Hi @HenryNdubuaku thanks for the review Done in fe40d27. Internal API:
Public API:
Let me know if I missed something! |
yujonglee
changed the title
Signed-off-by: HenryNdubuaku <[email protected]>
ncylich
pushed a commit
that referenced
this pull request
Feb 24, 2026
* add STFT_COMPLEX Signed-off-by: Yujong Lee <[email protected]> * change based on review * Cleanup Signed-off-by: HenryNdubuaku <[email protected]> --------- Signed-off-by: Yujong Lee <[email protected]> Signed-off-by: HenryNdubuaku <[email protected]> Co-authored-by: HenryNdubuaku <[email protected]>
cattermelon1234
pushed a commit
to cattermelon1234/cactus
that referenced
this pull request
Feb 28, 2026
…-compute#395) * add STFT_COMPLEX Signed-off-by: Yujong Lee <[email protected]> * change based on review * Cleanup Signed-off-by: HenryNdubuaku <[email protected]> --------- Signed-off-by: Yujong Lee <[email protected]> Signed-off-by: HenryNdubuaku <[email protected]> Co-authored-by: HenryNdubuaku <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STFT Magnitude:
0.615msSTFT Complex:
0.603msin my testing.