Conversation
Signed-off-by: justinl66 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR updates the Cactus telemetry pipeline to stop emitting tool/function call details in recorded telemetry events.
Changes:
- Telemetry event serialization now always emits
"function_calls": nullfor cloud payloads and cached logs. - FFI completion telemetry (
CompletionMetrics) no longer passes function call JSON into telemetry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cactus/telemetry/telemetry.cpp |
Forces function_calls to null in both cloud upload payloads and local cache logs. |
cactus/ffi/cactus_complete.cpp |
Stops attaching function call JSON to completion telemetry metrics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| metrics.prefill_tokens = prompt_tokens; | ||
| metrics.decode_tokens = completion_tokens; | ||
| metrics.error_message = nullptr; | ||
| metrics.function_calls_json = function_calls_json.c_str(); | ||
| metrics.function_calls_json = nullptr; | ||
| cactus::telemetry::recordCompletion(handle->model_name.c_str(), metrics); |
There was a problem hiding this comment.
serialize_function_calls(function_calls) is still executed (and assigned to function_calls_json) but metrics.function_calls_json is now set to nullptr, so the serialized value is unused. This adds unnecessary work and may trigger an unused-variable warning depending on compiler flags. Consider removing the function_calls_json local (and the serialization call) when telemetry is intentionally not recording function calls.
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Remove function call logging