Merged
Conversation
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: justinl66 <[email protected]>
This reverts commit 41fe9db. Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
cactus/ffi/cactus_vad.cpp
Outdated
| auto start_time = std::chrono::high_resolution_clock::now(); | ||
| auto* handle = static_cast<CactusModelHandle*>(model); | ||
| auto* vad_model = static_cast<SileroVADModel*>(handle->model.get()); | ||
| auto* vad_model = static_cast<SileroVADModel*>(handle->vad_model.get()); |
Collaborator
There was a problem hiding this comment.
This is quite wrong and breaks cactus transcribe.
This reverts commit a00c2dd. Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
Signed-off-by: justinl66 <[email protected]>
ncylich
pushed a commit
that referenced
this pull request
Feb 24, 2026
* Add native tests Signed-off-by: justinl66 <[email protected]> * Update swift and flutter tests Signed-off-by: justinl66 <[email protected]> * Add android tests Signed-off-by: justinl66 <[email protected]> * Update README Signed-off-by: justinl66 <[email protected]> * Flutter Fixes Signed-off-by: justinl66 <[email protected]> * Fix android gradle build Signed-off-by: justinl66 <[email protected]> * Fixes Signed-off-by: justinl66 <[email protected]> * Remove native tests folder Signed-off-by: justinl66 <[email protected]> * Fixes reapplied Signed-off-by: justinl66 <[email protected]> * Revert "Remove native tests folder" This reverts commit 41fe9db. Signed-off-by: justinl66 <[email protected]> * Wrapper fixes Signed-off-by: justinl66 <[email protected]> * Remove native tests folder Signed-off-by: justinl66 <[email protected]> * Revert "Remove native tests folder" This reverts commit a00c2dd. Signed-off-by: justinl66 <[email protected]> * Fix breaking VAD change Signed-off-by: justinl66 <[email protected]> * Remove native tests Signed-off-by: justinl66 <[email protected]> --------- Signed-off-by: justinl66 <[email protected]>
cattermelon1234
pushed a commit
to cattermelon1234/cactus
that referenced
this pull request
Feb 28, 2026
* Add native tests Signed-off-by: justinl66 <[email protected]> * Update swift and flutter tests Signed-off-by: justinl66 <[email protected]> * Add android tests Signed-off-by: justinl66 <[email protected]> * Update README Signed-off-by: justinl66 <[email protected]> * Flutter Fixes Signed-off-by: justinl66 <[email protected]> * Fix android gradle build Signed-off-by: justinl66 <[email protected]> * Fixes Signed-off-by: justinl66 <[email protected]> * Remove native tests folder Signed-off-by: justinl66 <[email protected]> * Fixes reapplied Signed-off-by: justinl66 <[email protected]> * Revert "Remove native tests folder" This reverts commit 41fe9db. Signed-off-by: justinl66 <[email protected]> * Wrapper fixes Signed-off-by: justinl66 <[email protected]> * Remove native tests folder Signed-off-by: justinl66 <[email protected]> * Revert "Remove native tests folder" This reverts commit a00c2dd. Signed-off-by: justinl66 <[email protected]> * Fix breaking VAD change Signed-off-by: justinl66 <[email protected]> * Remove native tests Signed-off-by: justinl66 <[email protected]> --------- Signed-off-by: justinl66 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.