Merged
Conversation
Signed-off-by: Karen Mosoyan <[email protected]>
Signed-off-by: Karen Mosoyan <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in entropy calculation for Vision-Language Models (VLM) where logits buffers with multiple sequence dimensions were not being handled correctly.
Changes:
- Fixed entropy calculation to correctly extract the last token's logits from multi-dimensional logits buffers
- Applied the fix consistently across both the VLM model (
model_lfm2vl.cpp) and the base engine model (engine_model.cpp)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cactus/models/model_lfm2vl.cpp | Added logic to handle multi-dimensional logits buffers by computing row offset to extract the last sequence position; removed unused blank line; added <numeric> header (unused) |
| cactus/engine/engine_model.cpp | Added identical multi-dimensional logits handling logic for consistency with VLM model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Goldokpa
pushed a commit
to Goldokpa/cactus
that referenced
this pull request
Feb 11, 2026
* fixed entropy calculation for vlm Signed-off-by: Karen Mosoyan <[email protected]> * reverted run.sh change Signed-off-by: Karen Mosoyan <[email protected]> * Update cactus/models/model_lfm2vl.cpp Co-authored-by: Copilot <[email protected]> --------- Signed-off-by: Karen Mosoyan <[email protected]> Co-authored-by: Copilot <[email protected]>
ncylich
pushed a commit
that referenced
this pull request
Feb 24, 2026
* fixed entropy calculation for vlm Signed-off-by: Karen Mosoyan <[email protected]> * reverted run.sh change Signed-off-by: Karen Mosoyan <[email protected]> * Update cactus/models/model_lfm2vl.cpp Co-authored-by: Copilot <[email protected]> --------- Signed-off-by: Karen Mosoyan <[email protected]> Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.