-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use with non-image files? #24
Comments
go-camo was indeed originally intended to proxy only images, for two reasons:
Later, a fork was created by a user to additionally proxy fonts and css. I wasn't comfortable including those in go-camo -- see discussion on #20. In my experience, video files are "usually" either linked (by url, no content warning), uploaded (service hosts it, so no content warning), or inlined from some hosting service (eg. youtube, vimeo; ssl provided by service). Video files are also generally much larger than image content. Can you further describe your use-case/requirements for proxying video? |
Ah, I can see why css/js could be an issue for some uses. I'm using this on the server side of my new social reader application so that all image/video URLs presented to the reader apps are https and from the same origin. The videos come from either Instagram, Twitter, or peoples' own blogs hosting video files directly. Because the majority of the content is twitter-like short posts, the video files are normally always under a minute long so they aren't actually that big. |
I am tentatively considering adding a cli flag to allow a few additional content types (like |
While you're at it, a command line flag to change the maximum allowed file size would also be appreciated! I am running into that limit now with proxying some video files. |
@aaronpk there already happens to be a flag for max size. From the
Note: The size is specified in Kilobytes (KB), with the default being 5120KB == 5MB. |
I have a branch up allow-video, with the new flag Note: I haven't been able to test it much, as the current system I use it on wouldn't allow this additional functionality. If you have time to test it, let me know. |
should be closed by a92ce5e |
Is there a particular reason this is limited to image files? I am using it on a service where I also proxy video files. It was easiest for me to disable the check for the image header and allow anything through. It might be nice if this was a config option to either allow proxying anything, or lock down by type.
The text was updated successfully, but these errors were encountered: