daemon: fall back to os.tmpdir if the socket path is too long#209
Merged
daemon: fall back to os.tmpdir if the socket path is too long#209
Conversation
65658f6 to
015ad09
Compare
The socket path limit on macOS is 104 characters. This limit is easily exceeded by a combination of nested runner directories and a particularly long runner name. If this happens, let's fall back to the default system tmpdir and create our socket there.
015ad09 to
005ab3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket path limit on macOS is 104 characters.
This limit is easily exceeded by a combination of nested runner directories and a particularly long runner name. If this happens, let's fall back to the default system tmpdir and create our socket there.