dev: enable shellcheck and lint

sandydoo · sandydoo · commit a7ae943f0b6a · 2025-07-04T16:36:25.000+02:00
diff --git a/devenv.nix b/devenv.nix
@@ -19,16 +19,20 @@ in
   };
 
   git-hooks.hooks = {
-    prettier = {
-      enable = true;
-      files = "(src/.*\.ts|.*\.md|.*\.yml)$";
-    };
-    nixfmt-rfc-style.enable = true;
     build-dist = {
       enable = true;
       files = "src/.*$";
       pass_filenames = false;
       entry = "devenv shell -- pnpm build";
     };
+    nixfmt-rfc-style.enable = true;
+    prettier = {
+      enable = true;
+      files = "(src/.*\.ts|.*\.md|.*\.yml)$";
+    };
+    shellcheck = {
+      enable = true;
+      excludes = [ "\\.envrc" ];
+    };
   };
 }
diff --git a/dist/push-paths.sh b/dist/push-paths.sh
@@ -8,15 +8,13 @@ filterPaths() {
   local paths=$2
 
   for path in $paths; do
-    echo $path | grep -vEe $regex
+    echo "$path" | grep -vEe "$regex"
   done | xargs
 }
 
 pathsToPush=""
-preBuildPaths=$(sort "$preBuildPathsFile")
-if [ $? -eq 0 ]; then
-  postBuildPaths=$("$(dirname "$0")"/list-nix-store.sh | sort)
-  if [ $? -eq 0 ]; then
+if preBuildPaths=$(sort "$preBuildPathsFile"); then
+  if postBuildPaths=$("$(dirname "$0")"/list-nix-store.sh | sort); then
     pathsToPush=$(comm -13 <(echo "$preBuildPaths") <(echo "$postBuildPaths"))
   else
     echo "::error::Failed to list post-build store paths."
@@ -26,7 +24,7 @@ else
 fi
 
 if [[ -n $pushFilter ]]; then
-  pathsToPush=$(filterPaths $pushFilter "$pathsToPush")
+  pathsToPush=$(filterPaths "$pushFilter" "$pathsToPush")
 fi
 
-echo "$pathsToPush" | "$cachix" push $cachixArgs "$cache"
+echo "$pathsToPush" | "$cachix" push "$cachixArgs" "$cache"
