Fix non empty struct pointer value#236
Merged
caarlos0 merged 1 commit intocaarlos0:mainfrom Sep 12, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
===========================================
+ Coverage 99.72% 100.00% +0.27%
===========================================
Files 2 2
Lines 358 356 -2
===========================================
- Hits 357 356 -1
+ Misses 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Owner
|
I don't remember why either, but, if all tests are passing, should be fine! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the bug #235
I can't understand the purpose of condition !refField.IsNil() but for this use case it was considering it as non empty value (line 229), calling ParseWithFuncs (line 234) and failing due to non struct type (line 190).
I have removed it and added extra tests for that use case and all UTs are ok
@caarlos0 can you please take a look?