bigquery: drop timestamp string replacement

c0b · c0b · commit baf97e54a6e2 · 2017-10-02T20:05:44.000-07:00
since https://issuetracker.google.com/issues/35905946 is fixed, bq server side now support RFC3339 format natively, hence no longer necessary to do string replacement for timestamp RFC3339 format $ node -p 'new Date().toJSON()' 2017-10-03T02:41:33.693Z $ bq query --parameter ts:TIMESTAMP:'2017-10-03T02:41:33.693Z' '#standardSQL SELECT FORMAT("%T", @ts) AS ts' Waiting on bqjob_r....... (0s) Current status: DONE +----------------------------------------+ | ts | +----------------------------------------+ | TIMESTAMP "2017-10-03 02:41:33.693+00" | +----------------------------------------+ with this change: $ node -e 'const bigquery = require("@google-cloud/bigquery")(); bigquery.query(`#standardSQL SELECT TIMESTAMP "2017-10-03T02:41:33.693Z" AS ts`) .then(([ res ]) => console.log(res))' [ { ts: { value: '2017-10-03T02:41:33.693Z' } } ] fixes googleapis#2631
diff --git a/packages/bigquery/src/index.js b/packages/bigquery/src/index.js
@@ -230,10 +230,7 @@ BigQuery.prototype.timestamp = function(value) {
     return new BigQuery.timestamp(value);
   }
 
-  value = new Date(value);
-  value = value.toJSON().replace(/^(.*)T(.*)Z$/, '$1 $2');
-
-  this.value = value;
+  this.value = new Date(value).toJSON();
 };
 
 /**
diff --git a/packages/bigquery/test/index.js b/packages/bigquery/test/index.js
@@ -276,7 +276,7 @@ describe('BigQuery', function() {
   describe('timestamp', function() {
     var INPUT_STRING = '2016-12-06T12:00:00.000Z';
     var INPUT_DATE = new Date(INPUT_STRING);
-    var EXPECTED_VALUE = '2016-12-06 12:00:00.000';
+    var EXPECTED_VALUE = '2016-12-06T12:00:00.000Z';
 
     it('should expose static and instance constructors', function() {
       var staticT = BigQuery.timestamp(INPUT_DATE);
