Fix leak and crash in ares_parse_a/aaaa_reply#264
Merged
bradh352 merged 3 commits intoc-ares:masterfrom Jun 24, 2019
ki11roy:fix_leak
Merged
Fix leak and crash in ares_parse_a/aaaa_reply#264bradh352 merged 3 commits intoc-ares:masterfrom ki11roy:fix_leak
bradh352 merged 3 commits intoc-ares:masterfrom
ki11roy:fix_leak
Conversation
Member
|
I agree they're quite common. I don't know what you mean by a .inc file, but you could definitely probably combine the functionality into a single conversion function, with a one-liner wrapper that is the parse_a/aaaa_reply. |
vadorovsky
pushed a commit
to vadorovsky/c-ares
that referenced
this pull request
Nov 1, 2019
* fix leak if naddress of particular type found * fix segfault when wanted ttls count lesser than count of result records * add fuzzer input files that trigger problems (from c-ares#263) Reported-By: David Drysdale (@daviddrysdale) Fix-By: Andrew Selivanov (@ki11roy)
DronRathore
pushed a commit
to DronRathore/c-ares
that referenced
this pull request
Mar 11, 2020
* fix leak if naddress of particular type found * fix segfault when wanted ttls count lesser than count of result records * add fuzzer input files that trigger problems (from c-ares#263) Reported-By: David Drysdale (@daviddrysdale) Fix-By: Andrew Selivanov (@ki11roy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes leak and crash in ares_parse_a/aaaa_reply. Borrowed fuzz files from #263.
@bradh352 By the way, I thought of moving common code somewhere in ares_parse_a_aaaa_reply.inc and including it into ares_parse_a_reply.c directly, what do you think of that?