Repository navigation
test(checkpoint): measure Postgres storage growth - #5051
Merged
WillemJiang merged 1 commit intoSep 1, 2026
Merged
Conversation
Ricky-7-Yan
force-pushed
the
test/checkpoint-storage-growth
branch
from
August 26, 2026 17:18
69a3492 to
6ffe77d
Compare
Ricky-7-Yan
marked this pull request as ready for review
August 31, 2026 15:35
WillemJiang
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4189
Why
The retention design in #4189 is intentionally blocked on a protected-set/deletion contract. Current coverage measures memory and SQLite growth, while the production Postgres saver has no equivalent full/delta storage-growth row. That leaves the retention discussion without comparable checkpoint/blob/write evidence across durable backends.
This PR is measurement-only. It does not define a retention policy, delete production history, or claim that any measured row is safe to prune.
What changed
bench_channels.pyaccepts an opt-inpostgresbackend whenTEST_POSTGRES_URIis set and runs it throughAsyncPostgresSaver.adelete_threadAPI.checkpoint_*,blob_*, andwrite_*row/byte fields for memory, SQLite, and Postgres, while retaining aggregate logical byte fields.SqliteSaverembeds channel values in its checkpoint payload; Postgres reportscheckpoint_blobsseparately. The docs call out that backend byte encodings are not directly identical.TEST_POSTGRES_URIis available.Surface area
frontend/backend/applanggraph.json, or prompt changedocker/or sandboxed executionskills/backend/pyproject.tomlorfrontend/package.json(say what it buys us)Screenshots / Recording
Not applicable; this changes a benchmark and its JSONL output.
Validation
pytest tests/test_bench_checkpoint_channels.py tests/test_summarize_checkpoint_channels.py tests/test_delta_channel_checkpointers.py -q— 48 passed, 5 skippedruff check .— passedruff format --check .— passed (1,234 files)TEST_POSTGRES_URIis not configured; the conditional test remains skipped in that environment.$env:PYTHONPATH='.;packages/harness;packages/extension-api'; uv run pytest -m "not live" tests/ -q) — 11,993 passed, 128 skipped, 230 failed, 82 errors in 20:17. None of the failures/errors are in the three related test modules; the non-zero cases are retained as current Windows/sparse-checkout environment evidence.AI assistance
Tool(s) used: Codex
How you used it: Used for issue and repository analysis, implementation assistance, test design, documentation, and validation.