fix(go): casting unsafe pointer to uintptr type#1493
fix(go): casting unsafe pointer to uintptr type#1493dicej merged 3 commits intobytecodealliance:mainfrom
Conversation
…mport_* functions Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
|
Also, the CI / Async test ran for a VERY long time, and I'm not sure why...When I ran them locally, the go tests passed without issue. |
Yes, please. Ideally it would be a minimal '*.wit' file under tests/codegen that hits the case you fixed.
Thanks for pointing that out. Looking back through https://github.com/bytecodealliance/wit-bindgen/actions, I'm seeing several six hour CI runs prior to this PR. I'll dig into it. |
|
I've opened #1495 for the CI issue. |
Signed-off-by: Andrew Steurer <[email protected]>
|
@dicej When you have a moment, this is ready for review |
2d98864
2 participants
This fixes a bug where
wit_async.SubtaskWait(uint32(wasm_import_method_*(params, returnArea)))will throw a compilation error because it expectsparamsto be typeuintptr. I discovered this when generating the bindings forwasi:[email protected].@dicej will you let me know if this needs additional test coverage?