feat(go): creating remote package for reusable bindings#1485
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom Jan 5, 2026
Merged
feat(go): creating remote package for reusable bindings#1485alexcrichton merged 3 commits intobytecodealliance:mainfrom
alexcrichton merged 3 commits intobytecodealliance:mainfrom
Conversation
asteurer
force-pushed
the
package
branch
10 times, most recently
from
b8feb32 to
a2f25bf
Compare
dicej
reviewed
Jan 5, 2026
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Thanks for doing this! LGTM overall; just a few comments inline.
asteurer
force-pushed
the
package
branch
3 times, most recently
from
ffc1ee4 to
b543a78
Compare
Signed-off-by: Andrew Steurer <[email protected]>
Collaborator
|
@asteurer When I run the tests locally and then run diff --git a/wit_component/go.mod b/wit_component/go.mod
index 1376492c..dd0a084c 100644
--- a/wit_component/go.mod
+++ b/wit_component/go.mod
@@ -2,4 +2,4 @@ module wit_component
go 1.25
-replace github.com/bytecodealliance/wit-bindgen => /home/asteurer/repos/wit-bindgen/crates/go/src/package
+replace github.com/bytecodealliance/wit-bindgen => /home/dicej/p/wit-bindgen/crates/go/src/packageIs there a way we could avoid putting local paths in a file tracked by Git? |
Contributor
Author
|
@dicej 🤦 That's an artifact from the runtime test that snuck in. I'll remove that real quick |
Signed-off-by: Andrew Steurer <[email protected]>
dicej
approved these changes
Jan 5, 2026
Collaborator
|
@alexcrichton any concerns about the new CI step (or any other aspect of this PR)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This closes #1484
Usage
Since the Go package hasn't yet been set up, you can try the new functionality by replacing the following line in the generated
wit_componentgo.mod file:@dicej