Merged
Conversation
Collaborator
|
Looks very good, I see a lot of code quality improvements and unifications (which even out the historically grown code base with newer additions like "move_if_necessary", and as usual the clippy warnings are significant quality improvements) |
cpetig
approved these changes
Nov 19, 2025
crates/test/src/cpp.rs
Outdated
| | "import_export_func.wit" | ||
| | "import-func.wit" | ||
| | "issue573.wit" | ||
| | "issue929-no-export.wit" |
Collaborator
There was a problem hiding this comment.
This file alone shows the quality improvement by this patch ;-)
Signed-off-by: Bailey Hayes <[email protected]>
ricochet
force-pushed
the
cpp-resources
branch
from
b4cc294 to
c4ffa5f
Compare
Signed-off-by: Bailey Hayes <[email protected]>
ricochet
force-pushed
the
cpp-resources
branch
from
c4ffa5f to
f2b08f9
Compare
Merged
via the queue into
bytecodealliance:main
with commit Nov 19, 2025
5ad77e0
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1424
This adds resource support for wit-bindgen cpp + clippy cleanups across the generator.
I think the remaining missing feature is covering multiversion. The rest all appear to be async wasip3.