Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winch Aarch64: signed_convert and unsigned_convert #9787

Merged
merged 2 commits into from
Dec 11, 2024
Merged

winch Aarch64: signed_convert and unsigned_convert #9787

merged 2 commits into from
Dec 11, 2024

Conversation

minirop
Copy link
Contributor

@minirop minirop commented Dec 11, 2024

Implement the following MASM instructions for the Aarch64 platform (#8321):

  • signed_convert
  • unsigned_convert

And fix mistakes introduced by #9767.

@minirop minirop requested review from a team as code owners December 11, 2024 15:38
@minirop minirop requested review from cfallin and alexcrichton and removed request for a team December 11, 2024 15:38
@cfallin cfallin requested a review from saulecabrera December 11, 2024 17:28
saulecabrera
saulecabrera reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a few typos below.

saulecabrera
saulecabrera approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad, I reviewed commit by commit and realized that in your second commit the documentation is fixed. Thanks!

@saulecabrera saulecabrera added this pull request to the merge queue Dec 11, 2024
Merged via the queue into bytecodealliance:main with commit d9f1e88 Dec 11, 2024
42 checks passed
@minirop minirop deleted the winch-convert-aarch64 branch December 12, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minirop @saulecabrera