winch: Track the callee calling convention #9757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aims to improve the consistency of call emission in Winch. Prior to this commit, the calling convention at Winch's assembler layer was hardcoded. Even though the calling convention invariants are correctly handled early on in the code generation process and this has no effect on the generated code, it could lead to subtle bugs if Cranelift's emission infrastructure changes. It could also be confusing when trying to implement call instrutions for other backends. This change is motivated by some of the questions in bytecodealliance#9751
fitzgen
approved these changes
Dec 6, 2024
MarinPostma
added a commit
to MarinPostma/wasmtime
that referenced
this pull request
Dec 6, 2024
MarinPostma
added a commit
to MarinPostma/wasmtime
that referenced
this pull request
Dec 7, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* implement trapz for aarch64 * implement call_with_name for aarch64 asm * implement call_with_reg for aarch64 asm * implement call_with_lib for aarch64 asm * tidy imports * implement address_at_vmctx for aarch64 masm * tidy imports * add tests * fmt pass * fix test after rebase * add some comments * pass calling convention down to asm after #9757 * s/Emits/Emit/ * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to improve the consistency of call emission in Winch.
Prior to this commit, the calling convention at Winch's assembler layer was hardcoded. Even though the calling convention invariants are correctly handled early on in the code generation process and this has no effect on the generated code, it could lead to subtle bugs if Cranelift's emission infrastructure changes. It could also be confusing when trying to implement call instrutions for other backends.
This change is motivated by some of the questions in #9751