[17.0.0] Close intermediate streams for reads/writes #7819
Merged
alexcrichton merged 1 commit intobytecodealliance:release-17.0.0from Jan 25, 2024
Merged
[17.0.0] Close intermediate streams for reads/writes #7819alexcrichton merged 1 commit intobytecodealliance:release-17.0.0from
alexcrichton merged 1 commit intobytecodealliance:release-17.0.0from
Conversation
Previously temporary streams created as part of the preview1 adapter in the wasmtime-wasi crate were left open which meant that they continued to occupy space in the resource table and the underlying file accidentally wasn't ever actually closed. cc bytecodealliance#7813
alexcrichton
changed the title
pchickey
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #7816 to the soon-to-be-released 17.0.0 branch.