cranelift-wasm: Add a small optimization for dynamic memories with min_size == max_size#7374
Merged
fitzgen merged 3 commits intobytecodealliance:mainfrom Oct 25, 2023
Conversation
…in_size == max_size` In this case, we don't need to load the dynamic heap bound from the vmctx because it actually has a constant size. Instead, we can use the constant directly.
fitzgen
requested review from
alexcrichton and
cfallin
and removed request for
a team
fitzgen
changed the title
cranelift-wasm: Add a small optimization for dynamic memories with min_size == max_size
alexcrichton
approved these changes
Oct 25, 2023
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Mind adding a test for a (memory 1 2) as well to ensure that a constant size isn't used?
fitzgen
commented
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case, we don't need to load the dynamic heap bound from the vmctx
because it actually has a constant size. Instead, we can use the constant
directly.