[12.0.0] Fix test expectations#7038
Merged
alexcrichton merged 2 commits intobytecodealliance:release-12.0.0from Sep 14, 2023
Merged
[12.0.0] Fix test expectations#7038alexcrichton merged 2 commits intobytecodealliance:release-12.0.0from
alexcrichton merged 2 commits intobytecodealliance:release-12.0.0from
Conversation
[automatically-tag-and-release-this-commit]
This was referenced Sep 14, 2023
Merged
Member
Author
|
I'll note that the automated release process for {12,11,10}.0.2 all failed due to the test failure that this is fixing. The corresponding PRs here all have the magical |
cfallin
approved these changes
Sep 14, 2023
* CI: upgrade to qemu 8.0.4. This should resolve a bug in qemu triggered by changes in bytecodealliance#6820 (see [here](bytecodealliance#6820 (comment))). * ci: Update QEMU patch for 8.0.2 --------- Co-authored-by: Afonso Bordado <[email protected]>
Member
Author
|
Emulated tests are failing quite a lot on CI for this and the 11/10 backports too. I'm not sure why. I recall these being flaky a few months ago. I'm going to shoot into the dark and pray that the update to QEMU 8.0.4 in CI fixes things, so I've backported that CI commit here too (and on #7039) |
veeshi
pushed a commit
to nethunterslabs/wasmtime
that referenced
this pull request
Sep 19, 2023
* Fix test expectations [automatically-tag-and-release-this-commit] * CI: upgrade to qemu 8.0.4. (bytecodealliance#6849) * CI: upgrade to qemu 8.0.4. This should resolve a bug in qemu triggered by changes in bytecodealliance#6820 (see [here](bytecodealliance#6820 (comment))). * ci: Update QEMU patch for 8.0.2 --------- Co-authored-by: Afonso Bordado <[email protected]> --------- Co-authored-by: Chris Fallin <[email protected]> Co-authored-by: Afonso Bordado <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a mistake in the prepared fixes for the recently published security advisory. I mistakenly forgot to run the full test suite locally which meant that some golden test expectations relevant to the bug in question weren't fixed.