Add a WASI test for a creating an absolute-path symlink.#6166
Merged
sunfishcode merged 1 commit intomainfrom Apr 8, 2023
Merged
Add a WASI test for a creating an absolute-path symlink.#6166sunfishcode merged 1 commit intomainfrom
sunfishcode merged 1 commit intomainfrom
Conversation
Wasmtime disallows guests from using `path_symlink` to create absolute-path symlinks, as they could confuse other code into accessing resources on the host that the guest otherwise doesn't have access to. This patch adds a test for this behavior.
jameysharp
approved these changes
Apr 6, 2023
brendandburns
pushed a commit
to brendandburns/wasmtime
that referenced
this pull request
Apr 13, 2023
…iance#6166) Wasmtime disallows guests from using `path_symlink` to create absolute-path symlinks, as they could confuse other code into accessing resources on the host that the guest otherwise doesn't have access to. This patch adds a test for this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasmtime disallows guests from using
path_symlinkto create absolute-path symlinks, as they could confuse other code into accessing resources on the host that the guest otherwise doesn't have access to.This patch adds a test for this behavior.