Skip to content

x64: Migrate fabs and bnot vector operations to ISLE#3535

Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom
alexcrichton:small-isle-patches
Nov 16, 2021
Merged

x64: Migrate fabs and bnot vector operations to ISLE#3535
fitzgen merged 1 commit intobytecodealliance:mainfrom
alexcrichton:small-isle-patches

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

This was my first attempt at transitioning code to ISLE to originally
fix #3327 but that fix has since landed on main, so this is instead
now just porting a few operations to ISLE.

Closes #3336

This was my first attempt at transitioning code to ISLE to originally
fix bytecodealliance#3327 but that fix has since landed on `main`, so this is instead
now just porting a few operations to ISLE.

Closes bytecodealliance#3336
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen isle Related to the ISLE domain-specific language labels Nov 16, 2021
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @cfallin, @fitzgen

Details This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Copy Markdown
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fitzgen fitzgen merged commit e0943b8 into bytecodealliance:main Nov 16, 2021
@alexcrichton alexcrichton deleted the small-isle-patches branch November 16, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x64: Different results with simd depending on optimization level x64: Incorrect codegen for f32x4.abs v128.not

2 participants