Cranelift CLIF Fuzzer add jump tables and br_table#3299
Merged
cfallin merged 2 commits intobytecodealliance:mainfrom Sep 3, 2021
Merged
Cranelift CLIF Fuzzer add jump tables and br_table#3299cfallin merged 2 commits intobytecodealliance:mainfrom
br_table#3299cfallin merged 2 commits intobytecodealliance:mainfrom
Conversation
32 tasks
github-actions
bot
added
the
cranelift
cfallin
approved these changes
Sep 3, 2021
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
LGTM overall!
Question below about how we ensure we always have at least one block that can go into a jumptable; with explanation in comment, I'm happy to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
A small addition to #3094. This is the last planned branch instruction for the CLIF fuzzer (since it looks like
brif/brffare going to be removed), and means that we have completed the branch / jump part of the fuzzer 🎉This change independently found #3100 which was fixed in #3282.