cranelift: Add stack support to the interpreter#3164
Closed
afonso360 wants to merge 1 commit intobytecodealliance:mainfrom
Closed
cranelift: Add stack support to the interpreter#3164afonso360 wants to merge 1 commit intobytecodealliance:mainfrom
afonso360 wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
afonso360
force-pushed
the
interpreter-stack
branch
from
9dc6f94 to
db32546
Compare
We also change the approach for heap loads and stores. Previously we would use the offset as the address to the heap. However, this approach does not allow using the load/store instructions to read/write from both the heap and the stack. This commit changes the addressing mechanism of the interpreter. We now return the real addresses from the addressing instructions (stack_addr/heap_addr), and instead check if the address passed into the load/store instructions points to an area in the heap or the stack.
afonso360
force-pushed
the
interpreter-stack
branch
from
db32546 to
67d605d
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "cranelift", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Contributor
Author
|
Closed in favor of #3187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we also change the approach for heap loads and stores.
Previously we would use the offset as the address to the heap. However, this approach does not allow using the
load/storeinstructions to read/write from both the heap and the stack.We now return the real addresses from the addressing instructions (
stack_addr/heap_addr), and instead check if the address passed into theload/storeinstructions points to an area in the heap or the stack.