Fix branching instructions in the interpreter#3062
Merged
abrown merged 8 commits intobytecodealliance:mainfrom Jul 19, 2021
Merged
Fix branching instructions in the interpreter#3062abrown merged 8 commits intobytecodealliance:mainfrom
abrown merged 8 commits intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
cranelift
bjorn3
reviewed
Jul 4, 2021
afonso360
force-pushed
the
interpreter-branches
branch
from
15ac5ff to
771c1ab
Compare
Member
|
@afonso360, what do you make of this failure? |
Contributor
Author
|
Hey, I think this is a bug in the aarch64 backend. I'll try to have a look at this today if possible. |
github-actions
bot
added
the
cranelift:area:aarch64
afonso360
force-pushed
the
interpreter-branches
branch
3 times, most recently
from
11890d2 to
490be9b
Compare
abrown
reviewed
Jul 7, 2021
Member
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
LGTM but let's wait for a review on the aarch64 part and some small fixes noted below.
cfallin
reviewed
Jul 7, 2021
afonso360
force-pushed
the
interpreter-branches
branch
from
4fe7212 to
e991271
Compare
abrown
approved these changes
Jul 9, 2021
Member
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
All my comments are resolved; I think this should be merged if we get a 👍 from @cfallin or @akirilov-arm on the aarch64 side.
afonso360
force-pushed
the
interpreter-branches
branch
from
e991271 to
074de80
Compare
akirilov-arm
suggested changes
Jul 13, 2021
afonso360
force-pushed
the
interpreter-branches
branch
2 times, most recently
from
08b44b2 to
bd3ad19
Compare
akirilov-arm
suggested changes
Jul 16, 2021
afonso360
force-pushed
the
interpreter-branches
branch
from
bd3ad19 to
bf551ba
Compare
akirilov-arm
approved these changes
Jul 16, 2021
Contributor
akirilov-arm
left a comment
akirilov-arm
left a comment
There was a problem hiding this comment.
The AArch64-related changes look good to me; there are a few nits that you can ignore.
afonso360
force-pushed
the
interpreter-branches
branch
from
bf551ba to
b04bcfd
Compare
akirilov-arm
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, branches were causing the interpreter to crash.