Skip to content

[RFC] Remove the old x86 backend #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 14 commits into from
Sep 30, 2021
Merged

[RFC] Remove the old x86 backend #3009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9e34df3
Remove the old x86 backend
bjorn3 Jun 18, 2021
59e18b7
Remove the old riscv backend
bjorn3 Jun 18, 2021
d8818c9
Fix all dead-code warnings in cranelift-codegen-meta
bjorn3 Jun 21, 2021
d499933
Remove encoding generation from cranelift-codegen-meta
bjorn3 Jun 21, 2021
18bd27e
Remove legalizer support from cranelift-codegen-meta
bjorn3 Jun 21, 2021
3e4167b
Remove registers from cranelift-codegen-meta
bjorn3 Jun 21, 2021
9e5201d
Fix all dead-code warnings in cranelift-codegen
bjorn3 Jun 21, 2021
53ec12d
Rustfmt
bjorn3 Jun 21, 2021
a646f68
Remove legacy x86_64 backend tests
bjorn3 Sep 29, 2021
7190718
Rustfmt
bjorn3 Sep 29, 2021
a204054
Remove unused fields
bjorn3 Sep 29, 2021
3fae9e5
Remove outdated tests from cranelift-codegen-meta
bjorn3 Sep 29, 2021
4b6d20d
Fix extend test for AArch64
bjorn3 Sep 29, 2021
463a88e
Rename lookup_variant to lookup
bjorn3 Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
22 changes: 0 additions & 22 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,28 +328,6 @@ jobs:
env:
RUST_BACKTRACE: 1

# Perform all tests (debug mode) for `wasmtime` with the old x86 backend.
test_x86:
name: Test old x86 backend
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: true
- uses: ./.github/actions/install-rust
with:
toolchain: stable

# Install wasm32 targets in order to build various tests throughout the
# repo.
- run: rustup target add wasm32-wasi
- run: rustup target add wasm32-unknown-unknown

# Run the old x86 backend CI (we will eventually remove this).
- run: ./ci/run-tests.sh --features old-x86-backend --locked
env:
RUST_BACKTRACE: 1

# Build and test the wasi-nn module.
test_wasi_nn:
name: Test wasi-nn module
Expand Down
3 changes: 0 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@ posix-signals-on-macos = ["wasmtime/posix-signals-on-macos"]
# backend is the default now.
experimental_x64 = []

# Use the old x86 backend.
old-x86-backend = ["wasmtime/old-x86-backend"]

[badges]
maintenance = { status = "actively-developed" }

Expand Down
5 changes: 0 additions & 5 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@ fn write_testsuite_tests(
fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool {
match strategy {
"Cranelift" => match (testsuite, testname) {
// Skip all reference types tests on the old backend. The modern
// implementation of reference types uses atomic instructions
// for reference counts on `externref`, but the old backend does not
// implement atomic instructions.
("reference_types", _) if cfg!(feature = "old-x86-backend") => return true,
// No simd support yet for s390x.
("simd", _) if platform_is_s390x() => return true,
// No memory64 support yet for s390x.
Expand Down
5 changes: 0 additions & 5 deletions cranelift/codegen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,17 @@ unwind = ["gimli"]
# If no ISA targets are explicitly enabled, the ISA target for the host machine is enabled.
x86 = []
arm64 = []
riscv = []
s390x = []
arm32 = [] # Work-in-progress codegen backend for ARM.

# Stub feature that does nothing, for Cargo-features compatibility: the new
# backend is the default now.
experimental_x64 = []

# Make the old x86 backend the default.
old-x86-backend = []

# Option to enable all architectures.
all-arch = [
"x86",
"arm64",
"riscv",
"s390x"
]

Expand Down
Loading