wasmtime-wasi-http: Only inject Host header in the default HTTP/1 send_request path#13138
Merged
Merged
Conversation
pchickey
approved these changes
Apr 20, 2026
vigoo
added a commit
to golemcloud/wasmtime
that referenced
this pull request
May 26, 2026
Ports the Golem fork's wasi-http changes from v42.0.1 onto v45.0.0: - Async bindgen imports for outgoing-handler.handle, future-incoming-response.get, future-trailers.get, incoming-body.finish/drop, incoming-response.drop, future-incoming-response.drop (matching v42 fork list) - HostFutureIncomingResponse::Deferred variant + activation logic in get() per trigger_deferred_on_ready.md - HttpConnectionPool extracted into new p2/connection_pool.rs module (with HttpConnectionPoolConfig, default_send_request_handler, default_send_request_with_pool, pooled_send_request_handler) - WasiHttpHooks::send_request takes body_completion: Option<BodyCompletionReceiver> - WasiHttpHooks::connection_pool() override hook - WasiHttpCtx::connection_pool field - HostIncomingBody: retain_worker(worker, error_receiver), retain_connection_permits, failing(error), take_stream() returns Box, worker_error_receiver and connection_permits fields - HostOutgoingBody: completion_sender + set_completion_sender, finish/abort signal completion - HostOutgoingRequest::body_completion field - HostIncomingResponse::pooled_connection field + poison_pooled_connection() - ConnWorkerErrorReceiver / ConnectionPermits types - DeferredSendFn type - IncomingResponse extended with worker_error_receiver, connection_permits, pooled_connection - FailingStream stream that always returns LastOperationFailed - Authority empty/missing rejection in handle() - Explicit Host header injection in handle() (matching post-v42 fix bytecodealliance#13138) - hyper-rustls bumped to 0.27 (compatible with rustls 0.23) - Re-export HttpConnectionPool/HttpConnectionPoolConfig from crate root Amp-Thread-ID: https://ampcode.com/threads/T-019e177d-4b8a-71ed-8739-f413107ed709 Co-authored-by: Amp <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
outgoing_handler::handleunconditionally appends aHostheader to the hyper::Request before callingWasiHttpView::send_request. This is fine for HTTP/1.1, but embedders that overridesend_requestto dispatch over HTTP/2 (e.g. viahyper_util::client::legacy::Clientnegotiating h2 through ALPN) end up sending both:authorityand ahostheader on the wire. Per RFC 9113 §8.3.1, clients generating HTTP/2 requests directly should use:authorityinstead ofHost, and strict servers such as Google's GFE reject the stream with RST_STREAM PROTOCOL_ERROR when both appear.This PR moves the
Hostinsertion out ofhandleand intodefault_send_request_handler, which is the only code path in this crate that terminates inhyper::client::conn::http1::handshake. HTTP/1 dispatch preserves the existing behavior, while customsend_requestimplementations no longer have to strip the header themselves.